netdev - Re: [PATCH net-next] net: dsa: select NET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d1fwurbw.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
Date:   Mon, 09 Jan 2017 11:32:35 -0500
From:   Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV

Hi Randy,

Randy Dunlap <rdunlap@...radead.org> writes:

> On 01/08/17 17:18, Florian Fainelli wrote:
>> On 01/08/2017 03:17 PM, Vivien Didelot wrote:
>>> DSA wraps SWITCHDEV, thus select it instead of depending on it.
>>>
>>> Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
>> 
>> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
>> 
>
> but when CONFIG_INET is not enabled, the patch causes this warning:
>
> warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET)

Thanks for spotting that! Would that be enough to change this first?

    diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig
    index 675acbf1502d..c7263b70e72b 100644
    --- a/net/dsa/Kconfig
    +++ b/net/dsa/Kconfig
    @@ -1,6 +1,6 @@
    config HAVE_NET_DSA
            def_bool y
    -       depends on NETDEVICES && !S390
    +       depends on INET && NETDEVICES && !S390

    # Drivers must select NET_DSA and the appropriate tagging format

Thanks,

        Vivien