netdev - Re: [PATCH net-next] liquidio: store the L4 hash of rx packets in skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170109185934.GA8823@felix.cavium.com>
Date:   Mon, 9 Jan 2017 10:59:34 -0800
From:   Felix Manlunas <felix.manlunas@...ium.com>
To:     David Miller <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <raghu.vatsavayi@...ium.com>,
        <derek.chickles@...ium.com>, <satananda.burla@...ium.com>,
        <eric.dumazet@...il.com>
Subject: Re: [PATCH net-next] liquidio: store the L4 hash of rx packets in skb

David Miller <davem@...emloft.net> wrote on Mon [2017-Jan-09 13:56:21 -0500]:
> From: Felix Manlunas <felix.manlunas@...ium.com>
> Date: Mon, 9 Jan 2017 10:45:05 -0800
> 
> > David Miller <davem@...emloft.net> wrote on Sun [2017-Jan-08 17:09:41 -0500]:
> >> From: Felix Manlunas <felix.manlunas@...ium.com>
> >> Date: Fri, 6 Jan 2017 16:55:42 -0800
> >> 
> >> >  
> >> > +		if (rh->r_dh.has_hash) {
> >> > +			u32 hash = be32_to_cpu(*(u32 *)(skb->data + r_dh_off));
> >> 
> >> Is the checksum defined to be in the first 4-bytes of the 8-byte DHLEN unit,
> >> or the second 4-bytes?  Is the answer to this question endian-dependent?
> > 
> > The hash is always in the first 4-bytes.  The location of the hash is endian
> > independent.  The hash itself (in its original form) is big endian.
> 
> Thanks for explaining.
> 
> Please fix the SPARSE issue Eric Dumazet mentioned.

Will do.  Thanks.