netdev - Re: [PATCHv2 net-next 0/5] sctp: add support for generating stream reconf chunks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170109124325.GB20973@hmswarspite.think-freely.org>
Date:   Mon, 9 Jan 2017 07:43:25 -0500
From:   Neil Horman <nhorman@...driver.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Vlad Yasevich <vyasevich@...il.com>, davem@...emloft.net
Subject: Re: [PATCHv2 net-next 0/5] sctp: add support for generating stream
 reconf chunks

On Sat, Jan 07, 2017 at 05:42:57PM +0800, Xin Long wrote:
> This patchset is to add some functions to generate stream reconf chunks,
> described in RFC6525 Section 3 and Section 4.
> 
> v1->v2:
>   - put these into a smaller group.
>   - rename some temporary variables in the codes.
>   - rename the titles of the commits and improve some changelogs.
> 
> Xin Long (5):
>   sctp: add a common helper function to generate stream reconf chunk
>   sctp: add support for generating stream reconf ssn reset request chunk
>   sctp: add support for generating stream reconf ssn/tsn reset request
>     chunk
>   sctp: add support for generating stream reconf response chunk
>   sctp: add support for generating stream reconf add streams request
>     chunk
> 
>  include/linux/sctp.h       |  68 ++++++++++++
>  include/net/sctp/sm.h      |  17 ++-
>  include/net/sctp/structs.h |   3 +
>  net/sctp/associola.c       |   1 +
>  net/sctp/sm_make_chunk.c   | 270 +++++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 358 insertions(+), 1 deletion(-)
> 
> -- 
> 2.1.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

These all look reasonably good, but it seems before we accept them,
there should be an additional patch that actually makes use of the code.
I presume that is forthcomming?

Neil