netdev - Re: [PATCH net-next 5/7] tcp_nv: make tcpnv_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D49A76C3.24037%brakmo@fb.com>
Date:   Tue, 10 Jan 2017 19:50:35 +0000
From:   Lawrence Brakmo <brakmo@...com>
To:     Stephen Hemminger <stephen@...workplumber.org>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Stephen Hemminger <sthemmin@...rosoft.com>
Subject: Re: [PATCH net-next 5/7] tcp_nv: make tcpnv_get_info static

On 1/10/17, 10:18 AM, "netdev-owner@...r.kernel.org on behalf of Stephen
Hemminger" <netdev-owner@...r.kernel.org on behalf of
stephen@...workplumber.org> wrote:

>Function only used in this file.
>
>Signed-off-by: Stephen Hemminger <sthemmin@...rosoft.com>
>---
> net/ipv4/tcp_nv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/net/ipv4/tcp_nv.c b/net/ipv4/tcp_nv.c
>index 5de82a8d4d87..0065f44c40c1 100644
>--- a/net/ipv4/tcp_nv.c
>+++ b/net/ipv4/tcp_nv.c
>@@ -424,8 +424,8 @@ static void tcpnv_acked(struct sock *sk, const struct
>ack_sample *sample)
> }
> 
> /* Extract info for Tcp socket info provided via netlink */
>-size_t tcpnv_get_info(struct sock *sk, u32 ext, int *attr,
>-		      union tcp_cc_info *info)
>+static size_t tcpnv_get_info(struct sock *sk, u32 ext, int *attr,
>+			     union tcp_cc_info *info)
> {
> 	const struct tcpnv *ca = inet_csk_ca(sk);
> 
>-- 
>2.11.0
>

You should also remove the line:
EXPORT_SYMBOL_GPL(tcpnv_get_info);