netdev - Re: [PATCH net] mlx4: Return EOPNOTSUPP instead of ENOTSUPP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e26d5f0-fed8-a2b9-392a-87da29c38758@cogentembedded.com>
Date:   Tue, 10 Jan 2017 15:43:39 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Martin KaFai Lau <kafai@...com>, netdev@...r.kernel.org
Cc:     Saeed Mahameed <saeedm@...lanox.com>,
        Tariq Toukan <tariqt@...lanox.com>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH net] mlx4: Return EOPNOTSUPP instead of ENOTSUPP

Hello!

On 01/10/2017 01:13 AM, Martin KaFai Lau wrote:

> In commit b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs"),
> it changed ENOTSUPP to EOPNOTSUPP by mistake.  This patch fixes it.

    You mean vice versa (looking at your patch)?

> Fixes: b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs")
> Signed-off-by: Martin KaFai Lau <kafai@...com>
> ---
>  drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> index edbe200ac2fa..4910d9af1933 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> @@ -2277,7 +2277,7 @@ static int mlx4_en_change_mtu(struct net_device *dev, int new_mtu)
>
>  	if (priv->tx_ring_num[TX_XDP] &&
>  	    !mlx4_en_check_xdp_mtu(dev, new_mtu))
> -		return -ENOTSUPP;
> +		return -EOPNOTSUPP;
>
>  	dev->mtu = new_mtu;
>

MBR, Sergei