netdev - Re: [PATCH net] net: ipv4: Fix multipath selection with vrf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170111.100027.559018351964620080.davem@davemloft.net>
Date:   Wed, 11 Jan 2017 10:00:27 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dsa@...ulusnetworks.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] net: ipv4: Fix multipath selection with vrf

From: David Ahern <dsa@...ulusnetworks.com>
Date: Tue, 10 Jan 2017 14:37:35 -0800

> fib_select_path does not call fib_select_multipath if oif is set in the
> flow struct. For VRF use cases oif is always set, so multipath route
> selection is bypassed. Use the FLOWI_FLAG_SKIP_NH_OIF to skip the oif
> check similar to what is done in fib_table_lookup.
> 
> Add saddr and proto to the flow struct for the fib lookup done by the
> VRF driver to better match hash computation for a flow.
> 
> Fixes: 613d09b30f8b ("net: Use VRF device index for lookups on TX")
> Signed-off-by: David Ahern <dsa@...ulusnetworks.com>
> ---
> IPv6 multipath selection works fine as is.

Applied and queued up for -stable, thanks David.