netdev - Re: net: ti: cpsw-phy-sel: RGMII is not working on AM335x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fd690450-e2a2-9bc6-1dd5-59cfce4e9caf@adaptrum.com>
Date:   Wed, 11 Jan 2017 12:18:54 -0800
From:   Alex <alex.g@...ptrum.com>
To:     Teresa Remmet <t.remmet@...tec.de>, Andrew Lunn <andrew@...n.ch>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Mugunthan V N <mugunthanvnm@...com>,
        Grygorii Strashko <grygorii.strashko@...com>,
        linux-omap@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: net: ti: cpsw-phy-sel: RGMII is not working on AM335x

Hi Teresa

On 01/11/2017 07:57 AM, Teresa Remmet wrote:
> The phy we use is a KSZ9021. And yes we add delays to the
> phy, as you can see. When looking to the dts documentation I probably
> need to set the phy-mode to "rgmii-id" instead, as the phy is providing
> the delays.

Before the change I submitted, every "rgmii*" link was being set up as 
"rgmii-id", regardless of phy-mode. I suspected there might have been 
the odd board here or there that used "rgmii" when the actual mode is 
"rgmii-id".

What confused me the first time around was that I didn't realize the 
delay applies to the phy, not the mac. So "-id" means "the PHY provides 
the delays, so don't add delays on the MAC", just like you realized.

> I make a quick test with that change and it is working. So this seems
> to solve my problem. Thank you for the hint.

I'm glad it was an easy fix. Last time I had issues with RGMII, I had to 
pull out the oscilloscope.

Alex

> Regards,
> Teresa
>