netdev - Re: [PATCH v2 2/2] stmmac: rename it to synopsys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Jan 2017 12:00:36 +0800
From:   Jie Deng <Jie.Deng1@...opsys.com>
To:     Joao Pinto <Joao.Pinto@...opsys.com>, <davem@...emloft.net>
CC:     <lars.persson@...s.com>, <niklass@...s.com>,
        <peppe.cavallaro@...com>, <alexandre.torgue@...com>,
        <netdev@...r.kernel.org>, <CARLOS.PALMINHA@...opsys.com>
Subject: Re: [PATCH v2 2/2] stmmac: rename it to synopsys

Hi Joao,


On 2017/1/10 22:52, Joao Pinto wrote:
> This patch renames stmicro/stmmac to synopsys/ since it is a standard
> ethernet software package regarding synopsys ethernet controllers, supporting
> the majority of Synopsys Ethernet IPs. The config IDs remain the same, for
> retro-compatibility, only the description was changed.
>
> Signed-off-by: Joao Pinto <jpinto@...opsys.com>
> ---
> changes v1->v2:
> - nothing changed. Just to keep up with patch set version
>
> @@ -1,5 +1,5 @@
>  config STMMAC_ETH
> -	tristate "STMicroelectronics 10/100/1000 Ethernet driver"
> +	tristate "Synopsys Ethernet drivers"
>  	depends on HAS_IOMEM && HAS_DMA
>  	select MII
>  	select PHYLIB
> @@ -14,7 +14,7 @@ config STMMAC_ETH
>  if STMMAC_ETH
>  
"Synopsys Ethernet drivers" is too generic. The name should reflect the
controller. This driver is for Synopsys GMAC 10M/100M/1G IPs. We will submit a
driver for the new 25G/40G/50G/100G XLGMAC IP in the future.
>  config STMMAC_PLATFORM
> -	tristate "STMMAC Platform bus support"
> +	tristate "Platform bus support"
>  	depends on STMMAC_ETH
>  	select MFD_SYSCON
>  	default y
> @@ -149,13 +149,13 @@ config DWMAC_SUNXI
>  endif
>  
>  config STMMAC_PCI
> -	tristate "STMMAC PCI bus support"
> +	tristate "PCI bus support"
>  	depends on STMMAC_ETH && PCI
>  	---help---
>  	  This is to select the Synopsys DWMAC available on PCI devices,
>  	  if you have a controller with this interface, say Y or M here.
>  
> -	  This PCI support is tested on XLINX XC2V3000 FF1152AMT0221
> +	  This PCI support was tested on XLINX XC2V3000 FF1152AMT0221
>  	  D1215994A VIRTEX FPGA board.
The name is also too generic. Please try to reflect the controller.

Thanks,
Jie