netdev - Re: [PATCH v4 0/4] vsock: cancel connect packets when failing to connect

Open Source and information security mailing list archives

Message-ID: <20170109100607.GA30228@stefanha-x1.localdomain>
Date:   Mon, 9 Jan 2017 10:06:07 +0000
From:   Stefan Hajnoczi <stefanha@...il.com>
To:     Peng Tao <bergwolf@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        virtualization@...ts.linux-foundation.org,
        Stefan Hajnoczi <stefanha@...hat.com>,
        Jorgen Hansen <jhansen@...are.com>, kvm@...r.kernel.org
Subject: Re: [PATCH v4 0/4] vsock: cancel connect packets when failing to
 connect

On Fri, Jan 06, 2017 at 10:22:56AM +0800, Peng Tao wrote:
> On Tue, Dec 13, 2016 at 5:50 PM, Stefan Hajnoczi <stefanha@...il.com> wrote:
> > On Mon, Dec 12, 2016 at 08:21:05PM +0800, Peng Tao wrote:
> >> Currently, if a connect call fails on a signal or timeout (e.g., guest is still
> >> in the process of starting up), we'll just return to caller and leave the connect
> >> packet queued and they are sent even though the connection is considered a failure,
> >> which can confuse applications with unwanted false connect attempt.
> >>
> >> The patchset enables vsock (both host and guest) to cancel queued packets when
> >> a connect attempt is considered to fail.
> >>
> >> v4 changelog:
> >>   - drop two unnecessary void * cast
> >>   - update new callback commnet
> >> v3 changelog:
> >>   - define cancel_pkt callback in struct vsock_transport rather than struct virtio_transport
> >>   - rename virtio_vsock_pkt->vsk to virtio_vsock_pkt->cancel_token
> >> v2 changelog:
> >>   - fix queued_replies counting and resume tx/rx when necessary
> >>
> >> Cheers,
> >> Tao
> >>
> >> Peng Tao (4):
> >>   vsock: track pkt owner vsock
> >>   vhost-vsock: add pkt cancel capability
> >>   vsock: add pkt cancel capability
> >>   vsock: cancel packets when failing to connect
> >>
> >>  drivers/vhost/vsock.c                   | 41 ++++++++++++++++++++++++++++++++
> >>  include/linux/virtio_vsock.h            |  2 ++
> >>  include/net/af_vsock.h                  |  3 +++
> >>  net/vmw_vsock/af_vsock.c                | 14 +++++++++++
> >>  net/vmw_vsock/virtio_transport.c        | 42 +++++++++++++++++++++++++++++++++
> >>  net/vmw_vsock/virtio_transport_common.c |  7 ++++++
> >>  6 files changed, 109 insertions(+)
> >>
> >> --
> >> 2.7.4
> >>
> >> _______________________________________________
> >> Virtualization mailing list
> >> Virtualization@...ts.linux-foundation.org
> >> https://lists.linuxfoundation.org/mailman/listinfo/virtualization
> >
> > Reviewed-by: Stefan Hajnoczi <stefanha@...hat.com>
> ping~
> 
> It looks like the patchsets are reviewed but not merged. Is there any blocker?

If Jorgen is sending pull requests then it should go through him.

Otherwise David Miller could apply it.

Stefan

Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives