netdev - Re: Correct method for initializing Pause and Asymmetrical Pause support in phy drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170112153535.GA10203@lunn.ch>
Date:   Thu, 12 Jan 2017 16:35:35 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Marc Bertola <marc.bertola@...lucid.ca>
Cc:     netdev@...r.kernel.org
Subject: Re: Correct method for initializing Pause and Asymmetrical Pause
 support in phy drivers

On Thu, Jan 12, 2017 at 10:21:29AM -0500, Marc Bertola wrote:
> Hello netdev list,
> 
> I am currently investigating a problem related to Ethernet
> auto-negotiation of Pause and Asymmetrical Pause capabilities.

Hi Marc

Have you read:

commit 2fa3e25b454e267d8f55ee19c27be540495463e7
Author: Florian Fainelli <f.fainelli@...il.com>
Date:   Sun Nov 27 18:45:13 2016 -0800

    Documentation: net: phy: Add a paragraph about pause frames/flow control
    
    Describe that the Ethernet MAC controller is ultimately responsible for
    dealing with proper pause frames/flow control advertisement and
    enabling, and that it is therefore allowed to have it change
    phydev->supported/advertising with SUPPORTED_Pause and
    SUPPORTED_AsymPause.
    
    Reviewed-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
    Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
    Signed-off-by: David S. Miller <davem@...emloft.net>

    Andrew