netdev - Re: [PATCH net-next 2/2] bpf: allow b/h/w/dw access for bpf's cb in ctx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <58776016.1050303@iogearbox.net>
Date:   Thu, 12 Jan 2017 11:53:10 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Quentin Monnet <quentin.monnet@...nd.com>, davem@...emloft.net
CC:     alexei.starovoitov@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] bpf: allow b/h/w/dw access for bpf's cb
 in ctx

On 01/12/2017 09:25 AM, Quentin Monnet wrote:
> 2017-01-12 (02:21 +0100) ~ Daniel Borkmann <daniel@...earbox.net>
[...]
>> diff --git a/tools/testing/selftests/bpf/test_verifier.c b/tools/testing/selftests/bpf/test_verifier.c
>> index 9bb4534..f664bed 100644
>> --- a/tools/testing/selftests/bpf/test_verifier.c
>> +++ b/tools/testing/selftests/bpf/test_verifier.c
>> @@ -859,15 +859,451 @@ struct test_val {
>
> [...]
>
>> +	{
>> +		"check cb access: doulbe, oob 5",
>> +		.insns = {
>> +			BPF_MOV64_IMM(BPF_REG_0, 0),
>> +			BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_1,
>> +				    offsetof(struct __sk_buff, cb[4]) + 8),
>> +			BPF_EXIT_INSN(),
>> +		},
>> +		.errstr = "invalid bpf_context access",
>> +		.result = REJECT,
>> +	},
>
> Nitpicking: typo ("doulbe").

Thanks for spotting, I've sent out a v2.