netdev - Re: [PATCH v5 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Jan 2017 17:38:03 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Alexander Loktionov <Alexander.Loktionov@...antia.com>,
        netdev@...r.kernel.org, David VomLehn <vomlehn@...as.net>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Simon Edelhaus <Simon.Edelhaus@...antia.com>,
        Dmitrii Tarakanov <Dmitrii.Tarakanov@...antia.com>,
        Pavel Belous <Pavel.Belous@...antia.com>
Subject: Re: [PATCH v5 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC
 driver

On 01/12/2017 09:02 PM, Alexander Loktionov wrote:
> From: David VomLehn <vomlehn@...as.net>
> 
> v1: Initial version
> v2: o Make necessary drivers/net/ethernet changes to integrate software
>     o Drop intermediate atlantic directory
>     o Remove Makefile things only appropriate to out of tree module
>       building
> v3: o Move changes to drivers/net/ethernet/{Kconfig,Makefile} to the last
>       patch to ensure clean bisection.
>     o Removed inline attribute aq_hw_write_req() as it was defined in
>       only one .c file.
>     o #included pci.h in aq_common.h to get struct pci definition.
>     o Modified code to unlock based execution flow rather than using a
>       flag.
>     o Made a number of functions that were only used in a single file
>       static.
>     o Cleaned up error and return code handling in various places.
>     o Remove AQ_CFG_IP_ALIGN definition.
>     o Other minor code clean up.
> v4: o Using do_div for 64 bit division.
>     o Modified NIC statistics code.
>     o Using build_skb instead netdev_alloc_skb for single fragment
>       packets.
>     o Removed extra aq_nic.o from Makefile
> v5: o Removed extra newline at the end of the files.
>     o Wrapped cover letter lines.

Have not looked at the driver yet, but the threading of your emails is
weird, each patch is in reply to the previous one. It would be more
natural to have all numbered patches be in reply to the cover letter,
which according to the version of git you seem to have used (2.7.4)
should already be the default. In graphical terms what we see right now is:

[PATCH 00/13]
	[PATCH 01/13]
		[PATCH 02/13]
			....

While we should see:


[PATCH 00/13]
	[PATCH 01/13]
	[PATCH 02/13]
	....

Can you fix that for future submissions, this may sound like a cosmetic
thing, but it really helps with threading/reading etc.

Thanks!
-- 
Florian