lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 14 Jan 2017 01:15:20 +0100
From:   Francois Romieu <>
To:     Cong Wang <>
Cc:     Linux Kernel Network Developers <>,
        Michal Hocko <>,
        Chas Williams <>,
        Andrey Konovalov <>
Subject: Re: [Patch net] atm: remove an unnecessary loop

Cong Wang <> :
> On Fri, Jan 13, 2017 at 5:23 AM, Francois Romieu <> wrote:
> > alloc_skb() does not need to be in the "while" loop.
> This is exactly what I describe in my changelog, don't know
> why you want to repeat it...

Because it is still hidden in a while loop. 

You turned the alloc from a two level deep "while" loop to a one level
one. I want it at zero level. alloc_skb(..., GFP_KERNEL) fails ?
So let it be done (see patch in other message).

> Please don't expect me to fix many things in one patch, let's
> fix each of them separately, agreed?

I am not convinced that several patches are needed to get the whole
picture right.


Powered by blists - more mailing lists