netdev - RE: [PATCH iproute2 v4 3/4] ifstat: Add 64 bits based stats to extended statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB5PR05MB18959E57F2BD8427DDEBDC89AC7A0@DB5PR05MB1895.eurprd05.prod.outlook.com>
Date:   Sun, 15 Jan 2017 13:54:57 +0000
From:   Nogah Frankel <nogahf@...lanox.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "roszenrami@...il.com" <roszenrami@...il.com>,
        "roopa@...ulusnetworks.com" <roopa@...ulusnetworks.com>,
        Jiri Pirko <jiri@...lanox.com>,
        Ido Schimmel <idosch@...lanox.com>,
        Elad Raz <eladr@...lanox.com>,
        Yotam Gigi <yotamg@...lanox.com>,
        Or Gerlitz <ogerlitz@...lanox.com>
Subject: RE: [PATCH iproute2 v4 3/4] ifstat: Add 64 bits based stats to
 extended statistics



> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@...workplumber.org]
> Sent: Friday, January 13, 2017 3:44 AM
> To: Nogah Frankel <nogahf@...lanox.com>
> Cc: netdev@...r.kernel.org; roszenrami@...il.com; roopa@...ulusnetworks.com; Jiri
> Pirko <jiri@...lanox.com>; Ido Schimmel <idosch@...lanox.com>; Elad Raz
> <eladr@...lanox.com>; Yotam Gigi <yotamg@...lanox.com>; Or Gerlitz
> <ogerlitz@...lanox.com>
> Subject: Re: [PATCH iproute2 v4 3/4] ifstat: Add 64 bits based stats to extended statistics
> 
> On Thu, 12 Jan 2017 15:49:50 +0200
> Nogah Frankel <nogahf@...lanox.com> wrote:
> 
> > The default stats for ifstat are 32 bits based.
> > The kernel supports 64 bits based stats. (They are returned in struct
> > rtnl_link_stats64 which is an exact copy of struct rtnl_link_stats, in
> > which the "normal" stats are returned, but with fields of u64 instead of
> > u32). This patch adds them as an extended stats.
> >
> > It is read with filter type IFLA_STATS_LINK_64 and no sub type.
> >
> > It is under the name 64bits
> > (or any shorten of it as "64")
> >
> > For example:
> > ifstat -x 64bit
> >
> > Signed-off-by: Nogah Frankel <nogahf@...lanox.com>
> > Reviewed-by: Jiri Pirko <jiri@...lanox.com>
> 
> Other commands (like ip link) always use the 64 bit statistics if available
> from the device. I see no reason that ifstat needs to be different.
> 

Do you mean to change the default ifstat results to be 64 bits based?
I tried it in the first version, but Roopa commented that it was not a good idea.
She said they tried it in the past and it caused backward compatibilities problems.
(Or maybe I didn't understand correctly)