netdev - Re: [PATCH next] ipvlan: fix dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170116.140514.1674761589594644492.davem@davemloft.net>
Date:   Mon, 16 Jan 2017 14:05:14 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     mahesh@...dewar.net
Cc:     netdev@...r.kernel.org, maheshb@...gle.com, davem@...emloft.org,
        edumazet@...gle.com
Subject: Re: [PATCH next] ipvlan: fix dev_id creation corner case.

From: Mahesh Bandewar <mahesh@...dewar.net>
Date: Fri, 13 Jan 2017 15:48:30 -0800

> From: Mahesh Bandewar <maheshb@...gle.com>
> 
> In the last patch da36e13cf65 ("ipvlan: improvise dev_id generation
> logic in IPvlan") I missed some part of Dave's suggestion and because
> of that the dev_id creation could fail in a corner case scenario. This
> would happen when more or less 64k devices have been already created and
> several have been deleted. If the devices that are still sticking around
> are the last n bits from the bitmap. So in this scenario even if lower
> bits are available, the dev_id search is so narrow that it always fails.
> 
> Fixes: da36e13cf65 ("ipvlan: improvise dev_id generation logic in IPvlan")
> CC: David Miller <davem@...emloft.org>
> CC: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>

Applied, thanks.