netdev - Re: [PATCH v2 net-next] IPsec: do not ignore crypto err in ah input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170116073535.GL3541@gauss.secunet.com>
Date:   Mon, 16 Jan 2017 08:35:35 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Gilad Ben-Yossef <gilad@...yossef.com>
CC:     <herbert@...dor.apana.org.au>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <ofir.drang@....com>,
        <gilad.benyossef@....com>,
        Alexander Alemayhu <alexander@...mayhu.com>
Subject: Re: [PATCH v2 net-next] IPsec: do not ignore crypto err in ah input

On Sun, Jan 15, 2017 at 08:09:43AM +0200, Gilad Ben-Yossef wrote:
> ah input processing uses the asynchronous hash crypto API which supplies 
> an error code as part of the operation completion but the error code was 
> being ignored.
> 
> Treat a crypto API error indication as a verification failure.
> 
> While a crypto API reported error would almost certainly result in a 
> memcmp of the digest failing anyway and thus the security risk seems 
> minor, performing a memory compare on what might be uninitialized memory 
> is wrong.
> 
> Signed-off-by: Gilad Ben-Yossef <gilad@...yossef.com>
> CC: Alexander Alemayhu <alexander@...mayhu.com>
> ---
> 
> The change was boot tested on Arm64 but I did not exercise
> the specific error code path in question.
> 
> Changes from v1:
> - Fixed typo in patch description pointed out by Alexander
> 
>  net/ipv4/ah4.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/net/ipv4/ah4.c b/net/ipv4/ah4.c
> index f2a7102..22377c8 100644
> --- a/net/ipv4/ah4.c
> +++ b/net/ipv4/ah4.c
> @@ -270,6 +270,9 @@ static void ah_input_done(struct crypto_async_request *base, int err)
>  	int ihl = ip_hdrlen(skb);
>  	int ah_hlen = (ah->hdrlen + 2) << 2;
>  
> +	if (err)
> +		goto out;
> +

IPv6 has the same problem, can we get it fixed there too?

Thanks!