[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170116092435.GA2970@mystictot>
Date: Mon, 16 Jan 2017 14:54:35 +0530
From: Shyam Saini <mayhs11saini@...il.com>
To: David Miller <davem@...emloft.net>
Cc: Yuval.Mintz@...ium.com, Ariel.Elior@...ium.com,
everest-linux-l2@...ium.com, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr
On Sun, Jan 15, 2017 at 11:38:30PM -0500, David Miller wrote:
>
> Please do not ever submit two patches which have the same exact commit
> header line, as these two patches do.
>
> When someone looks into the shortlog of GIT history all they will see
> is "qed: Replace memset with eth_zero_addr" twice.
>
> This gives the reader no idea what might be different between those
> two changes.
>
> Therefore you must give unique a commit header text for each change,
> which communicates sufficiently what is different in each change.
Thanks a lot for correcting me. I'll take care of this thing.
I'm resending these two patches as
1). qed: Replace memset with eth_zero_addr
2). qed: Use eth_zero_addr
I hope it resolves same commit header line conflict.
Regards,
Shyam
Powered by blists - more mailing lists