netdev - Re: [PATCH] sfc: Replace memset with eth_zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f1c75ec-3cad-0071-9f41-86773361281e@solarflare.com>
Date:   Mon, 16 Jan 2017 09:35:38 +0000
From:   Edward Cree <ecree@...arflare.com>
To:     Shyam Saini <mayhs11saini@...il.com>
CC:     <bkenward@...arflare.com>, <netdev@...r.kernel.org>,
        <linux-net-drivers@...arflare.com>
Subject: Re: [PATCH] sfc: Replace memset with eth_zero_addr

On 16/01/17 03:56, Shyam Saini wrote:
> Use eth_zero_addr to assign zero address to the given address array
> instead of memset when the second argument in memset is address
> of zero which makes the code clearer and also add header
> file linux/etherdevice.h
>
> Signed-off-by: Shyam Saini <mayhs11saini@...il.com>
> ---
Acked-by: Edward Cree <ecree@...arflare.com>
>  drivers/net/ethernet/sfc/ef10_sriov.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sfc/ef10_sriov.c b/drivers/net/ethernet/sfc/ef10_sriov.c
> index a949b9d..228806c 100644
> --- a/drivers/net/ethernet/sfc/ef10_sriov.c
> +++ b/drivers/net/ethernet/sfc/ef10_sriov.c
> @@ -6,6 +6,7 @@
>   * under the terms of the GNU General Public License version 2 as published
>   * by the Free Software Foundation, incorporated herein by reference.
>   */
> +#include <linux/etherdevice.h>
>  #include <linux/pci.h>
>  #include <linux/module.h>
>  #include "net_driver.h"
> @@ -554,7 +555,7 @@ int efx_ef10_sriov_set_vf_mac(struct efx_nic *efx, int vf_i, u8 *mac)
>  	return 0;
>  
>  fail:
> -	memset(vf->mac, 0, ETH_ALEN);
> +	eth_zero_addr(vf->mac);
>  	return rc;
>  }
>