netdev - Re: [PATCH v2] net: marvell: skge: use new api ethtool_{get|set}_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170117.114630.2113037516796589654.davem@davemloft.net>
Date:   Tue, 17 Jan 2017 11:46:30 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     tremyfr@...il.com
Cc:     mlindner@...vell.com, stephen@...workplumber.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: marvell: skge: use new api
 ethtool_{get|set}_link_ksettings

From: Philippe Reynes <tremyfr@...il.com>
Date: Mon, 16 Jan 2017 22:46:08 +0100

> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
> 
> The callback set_link_ksettings no longer update the value
> of advertising, as the struct ethtool_link_ksettings is
> defined as const.
> 
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
> 
> Signed-off-by: Philippe Reynes <tremyfr@...il.com>
> ---
> Changelog:
> v2:
> - update the commit log with a note to explain that this code
>   was not tested on hardware (feedback from Stephen Hemminger)

Applied.