netdev - Re: [net, 2/6] net: korina: define NAPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170117.124006.1559010522356313497.davem@davemloft.net>
Date:   Tue, 17 Jan 2017 12:40:06 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     leroi.lists@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [net, 2/6] net: korina: define NAPI_WEIGHT

From: Roman Yeryomin <leroi.lists@...il.com>
Date: Tue, 17 Jan 2017 19:32:22 +0200

> @@ -77,6 +77,8 @@
>  
>  #define MII_CLOCK 1250000 	/* no more than 2.5MHz */
>  
> +#define NAPI_WEIGHT	64
> +
>  /* the following must be powers of two */
>  #define KORINA_NUM_RDS	64  /* number of receive descriptors */
>  #define KORINA_NUM_TDS	64  /* number of transmit descriptors */
> @@ -1080,7 +1082,7 @@ static int korina_probe(struct platform_device *pdev)
>  	dev->netdev_ops = &korina_netdev_ops;
>  	dev->ethtool_ops = &netdev_ethtool_ops;
>  	dev->watchdog_timeo = TX_TIMEOUT;
> -	netif_napi_add(dev, &lp->napi, korina_poll, 64);
> +	netif_napi_add(dev, &lp->napi, korina_poll, NAPI_WEIGHT);

Please use NAPI_POLL_WEIGHT from linux/netdevice.h