netdev - Re: [PATCH] stmmac: add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170117.141054.244353366907267226.davem@davemloft.net>
Date:   Tue, 17 Jan 2017 14:10:54 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     Julia.Lawall@...6.fr
Cc:     peppe.cavallaro@...com, kernel-janitors@...r.kernel.org,
        alexandre.torgue@...com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] stmmac: add missing of_node_put

From: Julia Lawall <Julia.Lawall@...6.fr>
Date: Tue, 17 Jan 2017 12:23:21 +0100

> The function stmmac_dt_phy provides several possibilities for initializing
> plat->mdio_node, all of which have the effect of increasing the reference
> count of the assigned value.  This field is not updated elsewhere, so the
> value is live until the end of the lifetime of plat (devm_allocated), just
> after the end of stmmac_remove_config_dt.  Thus, add an of_node_put on
> plat->mdio_node in stmmac_remove_config_dt.  It is possible that the field
> mdio_node is never initialized, but of_node_put is NULL-safe, so it is also
> safe to call of_node_put in that case.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Applied, thanks Julia.