netdev - RE: [PATCHv1 5/7] TAP: Extending tap device create/destroy APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2C5142675EC1274EAB6230F72F8DC95F28C6C540@ORSMSX113.amr.corp.intel.com>
Date:   Tue, 17 Jan 2017 23:07:37 +0000
From:   "Grandhi, Sainath" <sainath.grandhi@...el.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "mahesh@...dewar.net" <mahesh@...dewar.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCHv1 5/7] TAP: Extending tap device create/destroy APIs



> -----Original Message-----
> From: Eric Dumazet [mailto:eric.dumazet@...il.com]
> Sent: Friday, January 06, 2017 3:16 PM
> To: Grandhi, Sainath <sainath.grandhi@...el.com>
> Cc: netdev@...r.kernel.org; davem@...emloft.net;
> mahesh@...dewar.net; linux-kernel@...r.kernel.org
> Subject: Re: [PATCHv1 5/7] TAP: Extending tap device create/destroy APIs
> 
> On Fri, 2017-01-06 at 14:33 -0800, Sainath Grandhi wrote:
> 
> > +static int tap_list_add(dev_t major, const char *device_name) {
> > +	int err = 0;
> > +	struct major_info *tap_major;
> > +
> > +	tap_major = kzalloc(sizeof(*tap_major), GFP_ATOMIC);
> > +
> > +	tap_major->major = MAJOR(major);
> > +
> 
> 
> kzalloc() can perfectly return NULL.
> 
> You do not want to crash it that happens.
> 
Thanks for pointing out. Will send out next version that takes care of null pointer