netdev - Re: [PATCH iproute2 net-next 0/5] add latest bridge netlink options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6cad896d-8ea3-64c7-9137-55609bd38e35@cumulusnetworks.com>
Date:   Tue, 17 Jan 2017 11:03:34 +0100
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2 net-next 0/5] add latest bridge netlink options

On 17/01/17 10:32, Hangbin Liu wrote:
> Add the bridge netlink attributes added to kernel recently.
> 
> Hangbin Liu (5):
>   iplink: bridge: add support for IFLA_BR_FDB_FLUSH
>   iplink: bridge: add support for IFLA_BR_VLAN_STATS_ENABLED
>   iplink: bridge: add support for IFLA_BR_MCAST_STATS_ENABLED
>   iplink: bridge: add support for IFLA_BR_MCAST_IGMP_VERSION
>   iplink: bridge: add support for IFLA_BR_MCAST_MLD_VERSION
> 
>  ip/iplink_bridge.c | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 56 insertions(+), 1 deletion(-)
> 

Cool, I also have a version of all of these patches just didn't get around to send them yet. :-)
Anyway since you're at it, you should also add support for IFLA_BRPORT_FLUSH,
but TBH I don't think the flush attributes should be used via this command, they seem
like an action that you do rather than an option that you set. That is the reason I
didn't add support for them awhile back when I added the others. But I don't have a
strong feeling about doing it via ip link set or not, so if the others are fine, I'm good too.

Cheers,
 Nik