[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20170117115537.021FE605A3@smtp.codeaurora.org>
Date: Tue, 17 Jan 2017 11:55:36 +0000 (UTC)
From: Kalle Valo <kvalo@...eaurora.org>
To: Arnd Bergmann <arnd@...db.de>
Cc: Amitkumar Karwar <akarwar@...vell.com>,
Arnd Bergmann <arnd@...db.de>,
Nishant Sarmukadam <nishants@...vell.com>,
Brian Norris <briannorris@...omium.org>,
Xinming Hu <huxm@...vell.com>, Cathy Luo <cluo@...vell.com>,
Shengzhen Li <szli@...vell.com>,
linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: mwifiex: fix uninitialized variable access in pcie_remove
Arnd Bergmann <arnd@...db.de> wrote:
> Checking the firmware status from PCIe register only works
> if the register is available, otherwise we end up with
> random behavior:
>
> drivers/net/wireless/marvell/mwifiex/pcie.c: In function 'mwifiex_pcie_remove':
> drivers/net/wireless/marvell/mwifiex/pcie.c:585:5: error: 'fw_status' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> This makes sure we treat the absence of the register as a failure.
>
> Fixes: 045f0c1b5e26 ("mwifiex: get rid of global user_rmmod flag")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Patch applied to wireless-drivers-next.git, thanks.
0e8edb9aed03 mwifiex: fix uninitialized variable access in pcie_remove
--
https://patchwork.kernel.org/patch/9515899/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists