netdev - Re: [PATCH net-next] net: Remove usage of net_device last

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1484760224.13165.108.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Wed, 18 Jan 2017 09:23:44 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Tobias Klauser <tklauser@...tanz.ch>
Cc:     netdev@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
        intel-wired-lan@...ts.osuosl.org, devel@...verdev.osuosl.org,
        b.a.t.m.a.n@...ts.open-mesh.org,
        Jay Vosburgh <j.vosburgh@...il.com>,
        Veaceslav Falico <vfalico@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        Mirko Lindner <mlindner@...vell.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH net-next] net: Remove usage of net_device last_rx member

On Wed, 2017-01-18 at 17:45 +0100, Tobias Klauser wrote:
> The network stack no longer uses the last_rx member of struct net_device
> since the bonding driver switched to use its own private last_rx in
> commit 9f242738376d ("bonding: use last_arp_rx in slave_last_rx()").
> 
> However, some drivers still (ab)use the field for their own purposes and
> some driver just update it without actually using it.
> 
> Previously, there was an accompanying comment for the last_rx member
> added in commit 4dc89133f49b ("net: add a comment on netdev->last_rx")
> which asked drivers not to update is, unless really needed. However,
> this commend was removed in commit f8ff080dacec ("bonding: remove
> useless updating of slave->dev->last_rx"), so some drivers added later
> on still did update last_rx.
> 
> Remove all usage of last_rx and switch three drivers (sky2, atp and
> smc91c92_cs) which actually read and write it to use their own private
> copy in netdev_priv.
> 
> Compile-tested with allyesconfig and allmodconfig on x86 and arm.

SGTM, thanks a lot for doing this Tobias.

Acked-by: Eric Dumazet <edumazet@...gle.com>