netdev - Re: [PATCH net] net: fix harmonize_features() vs NETIF_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Jan 2017 15:25:14 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     pshelar@....org, ashiduka@...fujitsu.com, fugang.duan@....com,
        netdev@...r.kernel.org, pshelar@...ira.com
Subject: Re: [PATCH net] net: fix harmonize_features() vs NETIF_F_HIGHDMA

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 18 Jan 2017 12:12:17 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Ashizuka reported a highmem oddity and sent a patch for freescale
> fec driver.
> 
> But the problem root cause is that core networking stack
> must ensure no skb with highmem fragment is ever sent through
> a device that does not assert NETIF_F_HIGHDMA in its features.
> 
> We need to call illegal_highdma() from harmonize_features()
> regardless of CSUM checks.
> 
> Fixes: ec5f06156423 ("net: Kill link between CSUM and SG features.")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Pravin Shelar <pshelar@....org>
> Reported-by: "Ashizuka, Yuusuke" <ashiduka@...fujitsu.com>

Applied, thanks Eric.

I guess few devices support SG and lack highmem support.