netdev - Re: [PATCH net] net: phy: bcm63xx: Utilize correct config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 18 Jan 2017 16:57:03 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, jonas.gorski@...il.com, dgcbueu@...il.com
Subject: Re: [PATCH net] net: phy: bcm63xx: Utilize correct config_intr
 function

From: Florian Fainelli <f.fainelli@...il.com>
Date: Tue, 17 Jan 2017 16:26:55 -0800

> From: Daniel Gonzalez Cabanelas <dgcbueu@...il.com>
> 
> Commit a1cba5613edf ("net: phy: Add Broadcom phy library for common
> interfaces") make the BCM63xx PHY driver utilize bcm_phy_config_intr()
> which would appear to do the right thing, except that it does not write
> to the MII_BCM63XX_IR register but to MII_BCM54XX_ECR which is
> different.
> 
> This would be causing invalid link parameters and events from being
> generated by the PHY interrupt.
> 
> Fixes: a1cba5613edf ("net: phy: Add Broadcom phy library for common interfaces")
> Signed-off-by: Daniel Gonzalez Cabanelas <dgcbueu@...il.com>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied and queued up for -stable, thanks!