netdev - Re: [PATCH net-next] net/sched: cls_flower: reduce fl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170119.112307.1679144601793219397.davem@davemloft.net>
Date:   Thu, 19 Jan 2017 11:23:07 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     jhs@...atatu.com, jiri@...lanox.com, hadarh@...lanox.com,
        amir@...ai.me, paulb@...lanox.com, ogerlitz@...lanox.com,
        simon.horman@...ronome.com, roid@...lanox.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net/sched: cls_flower: reduce fl_change stack
 size

From: Arnd Bergmann <arnd@...db.de>
Date: Thu, 19 Jan 2017 10:45:31 +0100

> The new ARP support has pushed the stack size over the edge on ARM,
> as there are two large objects on the stack in this function (mask
> and tb) and both have now grown a bit more:
> 
> net/sched/cls_flower.c: In function 'fl_change':
> net/sched/cls_flower.c:928:1: error: the frame size of 1072 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
> 
> We can solve this by dynamically allocating one or both of them.
> I first tried to do it just for the mask, but that only saved
> 152 bytes on ARM, while this version just does it for the 'tb'
> array, bringing the stack size back down to 664 bytes.
> 
> Fixes: 99d31326cbe6 ("net/sched: cls_flower: Support matching on ARP")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.