netdev - Re: [PATCH v7 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13303162-471c-de9c-a222-6bdbf5f38db9@gmail.com>
Date:   Thu, 19 Jan 2017 14:41:26 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Alexander Loktionov <Alexander.Loktionov@...antia.com>,
        netdev@...r.kernel.org, David VomLehn <vomlehn@...as.net>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Simon Edelhaus <Simon.Edelhaus@...antia.com>,
        Dmitrii Tarakanov <Dmitrii.Tarakanov@...antia.com>,
        Pavel Belous <Pavel.Belous@...antia.com>,
        Dmitry Bezrukov <Dmitry.Bezrukov@...antia.com>
Subject: Re: [PATCH v7 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC
 driver

On 01/19/2017 01:33 PM, Alexander Loktionov wrote:
> From: David VomLehn <vomlehn@...as.net>
> 
> This series introduces the AQtion NIC driver for the aQuantia
> AQC107/AQC108 network devices.

> v5: o Removed extra newline at the end of the files.
> v6: o Removed unnecessary cast from void*.
>     o Reworked strings array for ethtool statistics.
>     o Added stringset == ETH_SS_STATS checking.
>     o AQ_OBJ_HEADER replaced to aq_obj_header_s struct.
>     o AQ_OBJ_SET/TST/CLR macroses replaced to inline functions.
>     o Driver sources placed in to atlantic directory.
>     o Fixed compilation warnings (Make W=1)
>     o Added firmware version checking.
>     o Code cleaning.
> v7  o Removed unnecessary cast from memory allocation function (aq_ring.c).

In general, you may want for a couple of days before resubmitting new
versions that only fix minor stuff like what happened here between v6
and v7.

Some general comments on the coding style, it is usually preferred not
to name a structure e.g; struct foo_s, but just struct foo, you are also
saving bytes (and therefore trees!).
-- 
Florian