netdev - Re: [PATCH] Avoid in6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170118.214012.2158405175540797294.davem@davemloft.net>
Date:   Wed, 18 Jan 2017 21:40:12 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     zhengrq.fnst@...fujitsu.com
Cc:     netdev@...r.kernel.org, thomas.petazzoni@...e-electrons.com,
        maxin.john@...el.com
Subject: Re: [PATCH] Avoid in6_addr redefinition

From: Zheng Ruoqin <zhengrq.fnst@...fujitsu.com>
Date: Thu, 19 Jan 2017 10:25:16 +0800

> Due to both <netinet/in.h> and <linux/in6.h> being included, the 
> in6_addr is being redefined: once from the C library headers and once
> from the kernel headers. This causes some build failures with for 
> example the musl C library.
> 
> In order to fix this, use just the C library header <netinet/in.h>.
> Original patch taken from
> http://git.alpinelinux.org/cgit/aports/tree/main/iproute2/musl-fixes.patch.
> 
> (Refreshed the patch for 4.9 release)
> 
> Upstream-Status: Pending
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
> Signed-off-by: Maxin B. John <maxin.john@...el.com>
> Signed-off-by: Zheng Ruoqin <zhengrq.fnst@...fujitsu.com>

We have multiple definition avoidance using CPP tests, which works in
concert with GLIBC headers, that is supposed to avoid this properly.