netdev - Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Jan 2017 21:22:53 -0800
From:   Tom Herbert <tom@...bertland.com>
To:     David Miller <davem@...emloft.net>
Cc:     Saeed Mahameed <saeedm@....mellanox.co.il>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Doug Ledford <dledford@...hat.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        linux-rdma@...r.kernel.org, Leon Romanovsky <leon@...nel.org>
Subject: Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver
 directory layout

On Wed, Jan 18, 2017 at 9:32 AM, David Miller <davem@...emloft.net> wrote:
> From: Saeed Mahameed <saeedm@....mellanox.co.il>
> Date: Mon, 16 Jan 2017 22:30:29 +0200
>
>>> But please bear with me here, what if we queue this patch up to -stable ?
>
> You've got to be seriously kidding me that your idea is to submit an
> incredibly diruptive driver rename to -stable to solve this problem.
>
> That is completely a non-starter.
>
> The whole idea is to _MINIMIZE_ the amount of change happening in
> -stable in order to avoid regressions and negative consequence for
> everyone using the -stable tree.
>
> I am strongly against a major reorganization of this driver, sorry.
> The Synopsys folks want to do the same thing for the stmmac driver,
> for even more nefarious reasons, and I'm rejecting all of their
> attempts to do that as well.
>
> If you look in that thread, they said they would "help" with the
> -stable backports, and in there I explained why that is a completely
> empty gesture.  There are people doing the backports outside of your
> spehere of influence, who need to get their work done "right now" and
> aren't going to consult you and be on your schedule for doing those
> backports.

David,

In principle I  agree, but as I previously wrote backporting this
driver is already a bear. We need to do something here as this is
quickly approaching being infeasible to backport. Even if we don't
restructure the directories I'd still like to see some effort towards
feature modularization and isolation.

Tom