netdev - Re: [PATCH iproute2 net-next V2] tc: flower: Refactor matching flags to be more user friendly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aa0ff306-51f4-bacc-203b-e922be105204@mellanox.com>
Date:   Thu, 19 Jan 2017 16:14:43 +0200
From:   Paul Blakey <paulb@...lanox.com>
To:     Jiri Benc <jbenc@...hat.com>
CC:     <paulb@...lanox.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        <netdev@...r.kernel.org>, Jiri Pirko <jiri@...lanox.com>,
        Or Gerlitz <ogerlitz@...lanox.com>,
        Roi Dayan <roid@...lanox.com>,
        Simon Horman <simon.horman@...ronome.com>
Subject: Re: [PATCH iproute2 net-next V2] tc: flower: Refactor matching flags
 to be more user friendly



On 19/01/2017 16:04, Jiri Benc wrote:
> On Thu, 19 Jan 2017 14:17:57 +0200, Paul Blakey wrote:
>> Instead of "magic numbers" we can now specify each flag
>> by name. Prefix of "no_"  (e.g no_frag) unsets the flag,
>> otherwise it wil be set.
>
> Other parts of the tc tool use the "no" prefix (without the
> underscore), such as "nofrag" in u32 and pedit, "noecn" in fq_codel and
> pie, etc. We should follow the suit here.
>
> Looks good to me otherwise, thanks a lot for doing the work!
>
>  Jiri
>

Thanks, v3 is up.