netdev - Re: [PATCH net-next V4] tc: flower: Refactor matching flags to be more user friendly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b2c0b6b-0369-6588-ff17-a29a483942cb@mellanox.com>
Date:   Thu, 19 Jan 2017 16:29:34 +0200
From:   Paul Blakey <paulb@...lanox.com>
To:     Jiri Benc <jbenc@...hat.com>
CC:     <paulb@...lanox.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        <netdev@...r.kernel.org>, Jiri Pirko <jiri@...lanox.com>,
        Or Gerlitz <ogerlitz@...lanox.com>,
        Roi Dayan <roid@...lanox.com>,
        Simon Horman <simon.horman@...ronome.com>
Subject: Re: [PATCH net-next V4] tc: flower: Refactor matching flags to be
 more user friendly



On 19/01/2017 16:22, Jiri Benc wrote:
> On Thu, 19 Jan 2017 16:17:48 +0200, Paul Blakey wrote:
>> +	while (token) {
>> +		if (!strncmp(token, "no", 2)) {
>> +			no = true;
>> +			token = strchr(token, '_') + 1;
>
> This seems to still assume that "no" is followed by an underscore.
> What about a simple token += 2?
>
>  Jiri
>

Thanks again, v5 is sent.