[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20170120183606-mutt-send-email-mst@kernel.org>
Date: Fri, 20 Jan 2017 18:36:44 +0200
From: "Michael S. Tsirkin" <mst@...hat.com>
To: Volodymyr Bendiuga <volodymyr.bendiuga@...il.com>
Cc: davem@...emloft.net, nikolay@...ulusnetworks.com,
netdev@...r.kernel.org, volodymyr.bendiuga@...termo.se,
Jonas Johansson <jonas.johansson@...termo.se>
Subject: Re: [PATCH net-next] uapi: fix signess in ethtool_validate_speed()
On Fri, Jan 20, 2017 at 02:20:53PM +0100, Volodymyr Bendiuga wrote:
> From: Jonas Johansson <jonas.johansson@...termo.se>
>
> There is a comparison of speed variable which
> is unsigned, and SPEED_UNKNOWN which is signed.
So?
>
> Signed-off-by: Jonas Johansson <jonas.johansson@...termo.se>
> Signed-off-by: Volodymyr Bendiuga <volodymyr.bendiuga@...il.com>
> ---
> include/uapi/linux/ethtool.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
> index f0db778..1ca4a77 100644
> --- a/include/uapi/linux/ethtool.h
> +++ b/include/uapi/linux/ethtool.h
> @@ -1500,7 +1500,7 @@ enum ethtool_link_mode_bit_indices {
>
> #define SPEED_UNKNOWN -1
>
> -static inline int ethtool_validate_speed(__u32 speed)
> +static inline int ethtool_validate_speed(__s32 speed)
> {
> return speed <= INT_MAX || speed == SPEED_UNKNOWN;
> }
Then comparison to INT_MAX does not make sense.
> --
> 2.7.4
Powered by blists - more mailing lists