netdev - Re: [PATCH iproute2] f_flower: don't set TCA_FLOWER_KEY_ETH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170120093445.69306d0b@xeon-e3>
Date:   Fri, 20 Jan 2017 09:34:45 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Benjamin LaHaise <benjamin.lahaise@...ronome.com>
Cc:     netdev@...r.kernel.org, bcrl@...ck.org
Subject: Re: [PATCH iproute2] f_flower: don't set TCA_FLOWER_KEY_ETH_TYPE
 for "protocol all"

On Thu, 19 Jan 2017 16:51:59 -0500
Benjamin LaHaise <benjamin.lahaise@...ronome.com> wrote:

> When using the tc filter flower, rules marked with "protocol all" do not
> actually match all packets.  This is due to a bug in f_flower.c that passes
> in ETH_P_ALL in the TCA_FLOWER_KEY_ETH_TYPE attribute when adding a rule.
> Fix this by omitting TCA_FLOWER_KEY_ETH_TYPE if the protocol is set to
> ETH_P_ALL.
>     
> Signed-off-by: Benjamin LaHaise <benjamin.lahaise@...ronome.com>
> Signed-off-by: Benjamin LaHaise <bcrl@...ck.org>

This looks good, but does not apply cleanly to either master or net-next branch
of current repository. Please rebase and resubmit.

It would be helpful to to use Fixes: tag for something which was broken by
a single previous commit.