netdev - Re: [RFC PATCH] net: stmicro: eQOS IP Core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170120.112025.283503761726233382.davem@davemloft.net>
Date:   Fri, 20 Jan 2017 11:20:25 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     Joao.Pinto@...opsys.com
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        netdev@...r.kernel.org
Subject: Re: [RFC PATCH] net: stmicro: eQOS IP Core

From: Joao Pinto <Joao.Pinto@...opsys.com>
Date: Fri, 20 Jan 2017 12:27:33 +0000

> For historical reasons the Designware eQOS IP Core started in version 4.x,
> instead of starting in 1.x. This caused some misunderstanding, which resulted
> in calling this IP as GMAC4. If you go to Synopsys website and check the
> Ethernet portfolio there is no GMAC4 IP:
> https://www.synopsys.com/designware-ip/interface-ip/ethernet.html
> 
> There is a new version of eQOS comming out (5.x) that will have the same
> mac, dma registers and flow, with an extra set of registers to enable
> features like TSN. The creation of a dwmac5 or gmac5 would be wrong, and
> including those new features related to eQOS 5.x in dwmac4 would also not
> be very correct.
> 
> This patch suggests to rename dwmac4_* driver to eqos_*, turning it the
> official driver for eQOS IP. The registers definitions are also now
> called QOS_ instead of GMAC4_.
> 
> For more information about eQOS IP please check:
> https://www.synopsys.com/dw/ipdir.php?ds=dwc_ether_qos
> 
> Signed-off-by: Joao Pinto <jpinto@...opsys.com>

Sorry, you're not renaming every function in the driver that meets this
qualification.

I understand you want to work hard on the driver, but part of that is
_accepting_ things how they have been for years and making code
improvements and additions rather than messing around playing
rename-this/rename-that games until it looks how you want it to.

Please stop this charade of renaming, I'm getting really tired of it and
I think you really have no concept what kind of effect it has on people
who have to review, apply, and backport this code.

Kconfig text changes and clarifications, that's fine.  But all of these
function and variable name changes to the driver, and comment sweeps, no
it is not acceptable to me.