netdev - Re: [PATCH] net: mvneta: implement .set_wol and .get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201701221945.TgZOYvQL%fengguang.wu@intel.com>
Date:   Sun, 22 Jan 2017 19:13:58 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Jingju Hou <houjingj@...vell.com>
Cc:     kbuild-all@...org, davem@...emloft.net,
        thomas.petazzoni@...e-electrons.com, netdev@...r.kernel.org,
        Jingju Hou <houjingj@...vell.com>
Subject: Re: [PATCH] net: mvneta: implement .set_wol and .get_wol

Hi Jingju,

[auto build test ERROR on net-next/master]
[also build test ERROR on v4.10-rc4 next-20170120]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jingju-Hou/net-mvneta-implement-set_wol-and-get_wol/20170122-181651
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All error/warnings (new ones prefixed by >>):

   drivers/net/ethernet/marvell/mvneta.c: In function 'mvneta_ethtool_get_wol':
>> drivers/net/ethernet/marvell/mvneta.c:3940:8: error: 'struct mvneta_port' has no member named 'phy_dev'
     if (pp->phy_dev)
           ^
   drivers/net/ethernet/marvell/mvneta.c:3941:32: error: 'struct mvneta_port' has no member named 'phy_dev'
      return phy_ethtool_get_wol(pp->phy_dev, wol);
                                   ^
>> drivers/net/ethernet/marvell/mvneta.c:3941:3: warning: 'return' with a value, in function returning void
      return phy_ethtool_get_wol(pp->phy_dev, wol);
      ^
   drivers/net/ethernet/marvell/mvneta.c: In function 'mvneta_ethtool_set_wol':
   drivers/net/ethernet/marvell/mvneta.c:3949:9: error: 'struct mvneta_port' has no member named 'phy_dev'
     if (!pp->phy_dev)
            ^
   drivers/net/ethernet/marvell/mvneta.c:3952:31: error: 'struct mvneta_port' has no member named 'phy_dev'
     return phy_ethtool_set_wol(pp->phy_dev, wol);
                                  ^
>> drivers/net/ethernet/marvell/mvneta.c:3953:1: warning: control reaches end of non-void function [-Wreturn-type]
    }
    ^

vim +3940 drivers/net/ethernet/marvell/mvneta.c

  3934	{
  3935		struct mvneta_port *pp = netdev_priv(dev);
  3936	
  3937		wol->supported = 0;
  3938		wol->wolopts = 0;
  3939	
> 3940		if (pp->phy_dev)
> 3941			return phy_ethtool_get_wol(pp->phy_dev, wol);
  3942	}
  3943	
  3944	static int
  3945	mvneta_ethtool_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
  3946	{
  3947		struct mvneta_port *pp = netdev_priv(dev);
  3948	
> 3949		if (!pp->phy_dev)
  3950			return -EOPNOTSUPP;
  3951	
  3952		return phy_ethtool_set_wol(pp->phy_dev, wol);
> 3953	}
  3954	
  3955	static const struct net_device_ops mvneta_netdev_ops = {
  3956		.ndo_open            = mvneta_open,

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (48135 bytes)