netdev - Re: [net, 6/6] net: korina: version bump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACiydbKPNZyN+_+TDkHsbg0uGR51iDcqSTAQUMKyVCJ+u9wL7w@mail.gmail.com>
Date:   Sun, 22 Jan 2017 14:10:41 +0200
From:   Roman Yeryomin <leroi.lists@...il.com>
To:     Felix Fietkau <nbd@....name>
Cc:     netdev@...r.kernel.org
Subject: Re: [net, 6/6] net: korina: version bump

On 17 January 2017 at 21:19, Roman Yeryomin <leroi.lists@...il.com> wrote:
> On 17 January 2017 at 20:55, Felix Fietkau <nbd@....name> wrote:
>> On 2017-01-17 18:33, Roman Yeryomin wrote:
>>> Signed-off-by: Roman Yeryomin <roman@...em.lv>
>>> ---
>>>  drivers/net/ethernet/korina.c | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c
>>> index 83c994f..c8fed01 100644
>>> --- a/drivers/net/ethernet/korina.c
>>> +++ b/drivers/net/ethernet/korina.c
>>> @@ -66,8 +66,8 @@
>>>  #include <asm/mach-rc32434/dma_v.h>
>>>
>>>  #define DRV_NAME     "korina"
>>> -#define DRV_VERSION  "0.10"
>>> -#define DRV_RELDATE  "04Mar2008"
>>> +#define DRV_VERSION  "0.20"
>>> +#define DRV_RELDATE  "15Jan2017"
>> I think it would make more sense to remove this version instead of
>> bumping it. Individual driver versions are rather pointless, the kernel
>> version is more meaningful anyway.
>
> OK, makes sense

Actually, after thinking a bit more about this, not really...
How about ethtool, which uses driver name and version?
I see most ethernet drivers define some version. And it's pretty
useful, when using backports.
IMO, it should be kept and bumped.

Regards,
Roman