netdev - Re: [PATCH] net: mvneta: implement .set_wol and .get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 22 Jan 2017 17:49:35 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Jingju Hou <houjingj@...vell.com>
Cc:     davem@...emloft.net, thomas.petazzoni@...e-electrons.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: mvneta: implement .set_wol and .get_wol

On Sun, Jan 22, 2017 at 06:06:30PM +0800, Jingju Hou wrote:
> Signed-off-by: Jingju Hou <houjingj@...vell.com>

Hi Jingju

Please include a real comment here. Something like:

The mvneta itself does not support WOL, but the PHY might. So pass the
calls to the PHY.

It also looks like you are patching an old kernel. Network patches
like this need to be against net-next. You should also include
net-next in the subject line.

Thanks
	Andrew