netdev - Re: [PATCH net-next v5 1/1] net sched actions: Add support for user cookies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6fcf044a-5112-a1e2-4ee5-643cab8100e7@mojatatu.com>
Date:   Sun, 22 Jan 2017 14:44:50 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     Florian Fainelli <f.fainelli@...il.com>, davem@...emloft.net,
        netdev@...r.kernel.org, jiri@...lanox.com, paulb@...lanox.com,
        john.fastabend@...il.com, simon.horman@...ronome.com,
        mrv@...atatu.com, hadarh@...lanox.com, ogerlitz@...lanox.com,
        roid@...lanox.com, xiyou.wangcong@...il.com, daniel@...earbox.net
Subject: Re: [PATCH net-next v5 1/1] net sched actions: Add support for user
 cookies

On 17-01-22 02:32 PM, Jiri Pirko wrote:
> Sun, Jan 22, 2017 at 07:57:17PM CET, jhs@...atatu.com wrote:
>> On 17-01-22 01:13 PM, Florian Fainelli wrote:
>>>
>>>
>>
>>>
>>>> +		a->act_cookie->data = nla_memdup(tb[TCA_ACT_COOKIE],
>>>> +						 GFP_KERNEL);
>>>> +		if (!a->act_cookie->data) {
>>>> +			err = -ENOMEM;
>>>> +			tcf_hash_release(a, bind);
>>>> +			goto err_mod;
>>>> +		}
>>>
>>> Are not you leaking a->act_cookie here in case nla_memdup() fails here?
>>>
>>
>> yes, I am. Thanks for catching this. V6 coming up.
>
> Btw, you don't have to send cover letter for a single patch. In fact, you
> should not.
>

You can see i write small novels in my commit logs. Do you suggest i
put the git history there as well?

cheers,
jamal