netdev - Re: [PATCH net-next] bnx2x: avoid two atomic ops per page on x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170123.111803.192246884167319287.davem@davemloft.net>
Date:   Mon, 23 Jan 2017 11:18:03 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, krisman@...ux.vnet.ibm.com,
        Yuval.Mintz@...ium.com, ariel.elior@...ium.com
Subject: Re: [PATCH net-next] bnx2x: avoid two atomic ops per page on x86

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 20 Jan 2017 08:25:34 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Commit 4cace675d687 ("bnx2x: Alloc 4k fragment for each rx ring buffer
> element") added extra put_page() and get_page() calls on arches where
> PAGE_SIZE=4K like x86
> 
> Reorder things to avoid this overhead. 
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Gabriel Krisman Bertazi <krisman@...ux.vnet.ibm.com>
> Cc: Yuval Mintz <Yuval.Mintz@...ium.com>
> Cc: Ariel Elior <ariel.elior@...ium.com>

Applied, thanks.