netdev - Re: [PATCH net-next] net: stmicro: dwmac4 comments enhancement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170123.112042.989220998426190929.davem@davemloft.net>
Date:   Mon, 23 Jan 2017 11:20:42 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     Joao.Pinto@...opsys.com
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: stmicro: dwmac4 comments enhancement

From: Joao Pinto <Joao.Pinto@...opsys.com>
Date: Mon, 23 Jan 2017 15:56:24 +0000

> + * This is the driver for the DesignWare Ethernet QoS Controller.

This is fine.

> + * For historical reasons it started in 4.x version.

This provides no value whatsoever.

Please resist the urge to fidget and adjust random things, just get to
the point and make the minimum change necessary to achieve a specific,
well defined, constrained, objective.

Please!

I'm really getting irritated with how much effort is being expended
to make dilly-dally style changes that provide little or no value
to the driver.

Fix bugs and contribute new support for new chips, because this stuff
I'm seeing here is just eating up everyone's time rather than improving
the driver.

Thank you.