netdev - Re: [PATCH v4 1/3] bpf: add a longest prefix match trie map implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da8fb52a-ac48-2bc8-10a2-cd37247f2d2f@zonque.org>
Date:   Mon, 23 Jan 2017 17:42:28 +0100
From:   Daniel Mack <daniel@...que.org>
To:     Daniel Borkmann <daniel@...earbox.net>, ast@...com
Cc:     dh.herrmann@...il.com, netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH v4 1/3] bpf: add a longest prefix match trie map
 implementation

On 01/23/2017 05:39 PM, Daniel Borkmann wrote:
> On 01/21/2017 05:26 PM, Daniel Mack wrote:
> [...]
>> +/* Called from syscall or from eBPF program */
>> +static int trie_update_elem(struct bpf_map *map,
>> +			    void *_key, void *value, u64 flags)
>> +{
>> +	struct lpm_trie *trie = container_of(map, struct lpm_trie, map);
>> +	struct lpm_trie_node *node, *im_node, *new_node = NULL;
> 
> im_node is uninitialized here ...
> 
>> +	struct lpm_trie_node __rcu **slot;
>> +	struct bpf_lpm_trie_key *key = _key;
>> +	unsigned long irq_flags;
>> +	unsigned int next_bit;
>> +	size_t matchlen = 0;
>> +	int ret = 0;
>> +
>> +	if (unlikely(flags > BPF_EXIST))
>> +		return -EINVAL;
>> +
>> +	if (key->prefixlen > trie->max_prefixlen)
>> +		return -EINVAL;
>> +
>> +	raw_spin_lock_irqsave(&trie->lock, irq_flags);
>> +
>> +	/* Allocate and fill a new node */
>> +
>> +	if (trie->n_entries == trie->map.max_entries) {
>> +		ret = -ENOSPC;
>> +		goto out;
> 
> ... and here we go to out path with ret as non-zero ...
> 
>> +	}
>> +
>> +	new_node = lpm_trie_node_alloc(trie, value);
>> +	if (!new_node) {
>> +		ret = -ENOMEM;
>> +		goto out;
>> +	}
> [...]
>> +
>> +out:
>> +	if (ret) {
>> +		if (new_node)
>> +			trie->n_entries--;
>> +
>> +		kfree(new_node);
>> +		kfree(im_node);
> 
> ... which does kfree() in im_node here.

Oops. Nice catch! gcc was too stupid to recognize that :)

Thanks, I'll repost a v5 with Alexei's Acked-by later today.


Daniel