netdev - Re: [PATCH net-next 1/2] vxlan: don't flush static fdb entries on admin down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170123.160741.1558621534864494201.davem@davemloft.net>
Date:   Mon, 23 Jan 2017 16:07:41 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     roopa@...ulusnetworks.com
Cc:     netdev@...r.kernel.org, ramanb@...ulusnetworks.com,
        stephen@...workplumber.org, jbenc@...hat.com, pshelar@....org
Subject: Re: [PATCH net-next 1/2] vxlan: don't flush static fdb entries on
 admin down

From: Roopa Prabhu <roopa@...ulusnetworks.com>
Date: Fri, 20 Jan 2017 23:43:18 -0800

>  /* Purge the forwarding table */
> -static void vxlan_flush(struct vxlan_dev *vxlan)
> +static void vxlan_flush(struct vxlan_dev *vxlan, int do_all)

Please use 'bool' and true/false for this new argument.

FWIW, I am fine with changing the default behavior in this way.