netdev - Re: [patch net-next 1/4] net: Introduce psample, a new genetlink channel for packet sampling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170123155750.22f4b323@xeon-e3>
Date:   Mon, 23 Jan 2017 15:57:50 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, yotamg@...lanox.com,
        idosch@...lanox.com, eladr@...lanox.com, nogahf@...lanox.com,
        ogerlitz@...lanox.com, jhs@...atatu.com, geert+renesas@...der.be,
        xiyou.wangcong@...il.com, linux@...ck-us.net,
        roopa@...ulusnetworks.com, john.fastabend@...il.com,
        simon.horman@...ronome.com, mrv@...atatu.com
Subject: Re: [patch net-next 1/4] net: Introduce psample, a new genetlink
 channel for packet sampling

On Sun, 22 Jan 2017 12:44:44 +0100
Jiri Pirko <jiri@...nulli.us> wrote:

> +static LIST_HEAD(psample_groups_list);
> +static DEFINE_SPINLOCK(psample_groups_lock);
> +

Why not a mutex? You aren't acquiring this in IRQ context?