[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <92bad931-3028-4c95-2028-f52596439b77@cumulusnetworks.com>
Date: Sun, 22 Jan 2017 21:37:40 -0700
From: David Ahern <dsa@...ulusnetworks.com>
To: David Miller <davem@...emloft.net>
Cc: netdev@...r.kernel.org, xiaolong.ye@...el.com
Subject: Re: [PATCH net-next] net: ipv6: Check that idev is non-NULL in
rt6_fill_node
On 1/22/17 9:32 PM, David Miller wrote:
> From: David Ahern <dsa@...ulusnetworks.com>
> Date: Sun, 22 Jan 2017 20:08:00 -0800
>
>> The ipv6 route dump code passes ip6_null_entry to rt6_fill_node.
>
> Doesn't this fact cause you to take a pause?
yes, it did.
>
> I can't see a legitimate reason to dump the null entry, it's
> a marker rather than a real entry.
>
neither do I. I was rather surprised to see it hit rt6_fill_node and that the rc is 0.
I can send a v2 that drops null_entry.
Powered by blists - more mailing lists