netdev - Re: [PATCH] net: stmicro: fix LS field mask in EEE configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Jan 2017 11:01:08 +0530
From:   Rayagond Kokatanur <rayagond@...avyalabs.com>
To:     Joao Pinto <Joao.Pinto@...opsys.com>
Cc:     David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: stmicro: fix LS field mask in EEE configuration

Acked-by:Rayagond Kokatanur <rayagond@...avyalabs.com>

On Fri, Jan 20, 2017 at 9:30 PM, Joao Pinto <Joao.Pinto@...opsys.com> wrote:
> This patch fixes the LS mask when setting EEE timer.
> LS field is 10 bits long and not 11 as currently.
>
> Signed-off-by: Joao Pinto <jpinto@...opsys.com>
> Reported-By: Rayagond Kokatanur <rayagond@...avyalabs.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
> index 834f40f..202216c 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
> @@ -184,7 +184,7 @@ static void dwmac4_set_eee_pls(struct mac_device_info *hw, int link)
>  static void dwmac4_set_eee_timer(struct mac_device_info *hw, int ls, int tw)
>  {
>         void __iomem *ioaddr = hw->pcsr;
> -       int value = ((tw & 0xffff)) | ((ls & 0x7ff) << 16);
> +       int value = ((tw & 0xffff)) | ((ls & 0x3ff) << 16);
>
>         /* Program the timers in the LPI timer control register:
>          * LS: minimum time (ms) for which the link
> --
> 2.9.3
>



-- 
wwr
Rayagond