netdev - Re: [PATCH 3/3] sh_eth: stop using bare numbers for EESIPR values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWWFmDkJfhac9jLZ-ZAJfzDPw7oq4hwL5hVy21h0V13Og@mail.gmail.com>
Date:   Mon, 23 Jan 2017 09:00:49 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH 3/3] sh_eth: stop using bare numbers for EESIPR values

Hi Sergei,

On Sun, Jan 22, 2017 at 8:19 PM, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> Now  that we  have almost all EESIPR bits declared (and those that  are
> still not are most probably reserved anyway) we can at last replace the
> bare  numbers used for 'sh_eth_cpu_data::eesipr_value' initializers with
> the bit names ORed together...
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
>
> ---
>  drivers/net/ethernet/renesas/sh_eth.c |   89 +++++++++++++++++++++++++++++-----
>  1 file changed, 78 insertions(+), 11 deletions(-)
>
> Index: net-next/drivers/net/ethernet/renesas/sh_eth.c
> ===================================================================
> --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c
> +++ net-next/drivers/net/ethernet/renesas/sh_eth.c

> @@ -800,7 +843,12 @@ static struct sh_eth_cpu_data sh7734_dat
>
>         .ecsr_value     = ECSR_ICD | ECSR_MPD,
>         .ecsipr_value   = ECSIPR_LCHNGIP | ECSIPR_ICDIP | ECSIPR_MPDIP,
> -       .eesipr_value   = EESIPR_RFCOFIP | EESIPR_ECIIP | 0x003f07ff,
> +       .eesipr_value   = EESIPR_RFCOFIP | EESIPR_ECIIP |
> +                         EESIPR_FTCIP | EESIPR_TDEIP | EESIPR_TFUFIP |
> +                         EESIPR_FRIP | EESIPR_RDEIP | EESIPR_RFOFIP |

Missing:

        EESIPR_DLCIP | EESIPR_CDIP | EESIPR_TROIP |

> +                         EESIPR_RMAFIP | EESIPR_CEEFIP | EESIPR_CELFIP |
> +                         EESIPR_RRFIP | EESIPR_RTLFIP | EESIPR_RTSFIP |
> +                         EESIPR_PREIP | EESIPR_CERFIP,
>
>         .tx_check       = EESR_TC1 | EESR_FTC,
>         .eesr_err_check = EESR_TWB1 | EESR_TWB | EESR_TABT | EESR_RABT |
> @@ -830,7 +878,12 @@ static struct sh_eth_cpu_data sh7763_dat
>
>         .ecsr_value     = ECSR_ICD | ECSR_MPD,
>         .ecsipr_value   = ECSIPR_LCHNGIP | ECSIPR_ICDIP | ECSIPR_MPDIP,
> -       .eesipr_value   = EESIPR_RFCOFIP | EESIPR_ECIIP | 0x003f07ff,
> +       .eesipr_value   = EESIPR_RFCOFIP | EESIPR_ECIIP |
> +                         EESIPR_FTCIP | EESIPR_TDEIP | EESIPR_TFUFIP |
> +                         EESIPR_FRIP | EESIPR_RDEIP | EESIPR_RFOFIP |

Likewise

> +                         EESIPR_RMAFIP | EESIPR_CEEFIP | EESIPR_CELFIP |
> +                         EESIPR_RRFIP | EESIPR_RTLFIP | EESIPR_RTSFIP |
> +                         EESIPR_PREIP | EESIPR_CERFIP,

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds