netdev - Re: [PATCH net] net: reset ct before calling ndo_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1485266667.16328.290.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Tue, 24 Jan 2017 06:04:27 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Hannes Frederic Sowa <hannes@...essinduktion.org>,
        Florian Westphal <fw@...len.de>
Subject: Re: [PATCH net] net: reset ct before calling ndo_start_xmit

On Tue, 2017-01-24 at 10:40 +0100, Paolo Abeni wrote:

> Currently we use the NETIF_F_LLTX feature bit to identify such devices,
> since all the [legacy] phys drivers setting such bit are not prone
> the hangup issue. The plan is adding a specific 'this is a
> virtual device' priv flag and use it instead, in a later net-next
> patch.

This is too ugly in my opinion.

LLTX is LLTX, and has absolutely nothing to do with connection tracking.

We have ndo_features_check, and this can be trivially backported to
stable versions.

No need for yet another flag really.