netdev - Re: [PATCH net-next] bpf, lpm: fix kfree of im_node in trie_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170124003707.GA60699@ast-mbp.thefacebook.com>
Date:   Mon, 23 Jan 2017 16:37:09 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     davem@...emloft.net, ast@...nel.org, daniel@...que.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] bpf, lpm: fix kfree of im_node in
 trie_update_elem

On Tue, Jan 24, 2017 at 01:26:46AM +0100, Daniel Borkmann wrote:
> We need to initialize im_node to NULL, otherwise in case of error path
> it gets passed to kfree() as uninitialized pointer.
> 
> Fixes: b95a5c4db09b ("bpf: add a longest prefix match trie map implementation")
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>

Great catch.
Acked-by: Alexei Starovoitov <ast@...nel.org>